Skip to content

Commit d219a42

Browse files
committed
Optimize Hidden component: compute only required media queries
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
1 parent 8b7c3be commit d219a42

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/base/Hidden/Hidden.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,10 @@ export const Hidden = ({
3939
}: HiddenProps) => {
4040
const theme = useTheme();
4141

42-
const upProps: Record<Breakpoint, boolean> = { xs: xsUp, sm: smUp, md: mdUp, lg: lgUp, xl: xlUp };
43-
const downProps: Record<Breakpoint, boolean> = { xs: xsDown, sm: smDown, md: mdDown, lg: lgDown, xl: xlDown };
44-
4542
const mediaQuery = useMemo(() => {
4643
const onlyValues = Array.isArray(only) ? only : only ? [only] : [];
44+
const upProps: Record<Breakpoint, boolean> = { xs: xsUp, sm: smUp, md: mdUp, lg: lgUp, xl: xlUp };
45+
const downProps: Record<Breakpoint, boolean> = { xs: xsDown, sm: smDown, md: mdDown, lg: lgDown, xl: xlDown };
4746
const conditions: string[] = [];
4847

4948
for (const bp of BREAKPOINTS) {
@@ -59,7 +58,6 @@ export const Hidden = ({
5958
}
6059

6160
return conditions.length > 0 ? `@media ${conditions.join(', ')}` : '@media not all';
62-
6361
}, [only, xsUp, smUp, mdUp, lgUp, xlUp, xsDown, smDown, mdDown, lgDown, xlDown, theme.breakpoints]);
6462

6563
const matches = useMediaQuery(mediaQuery);

0 commit comments

Comments
 (0)