-
Notifications
You must be signed in to change notification settings - Fork 229
Description
What happened?
On the v0.144.0 binary release the resourcedetection processor was mistakenly not bumped to v0.144.0, leaving it on the v0.143.0 version.
This is the only module affected by this, as can be seen if one greps for the 143 version on the distributions folder:
Output of grep -R 143 on v0.144.0 commit
$ grep -R 143
otelcol-k8s/manifest.yaml: - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.143.0
otelcol-ebpf-profiler/manifest.yaml: - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.143.0
otelcol-contrib/manifest.yaml: - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.143.0What is the impact?
If you are using the official binaries for the otelcol-contrib, otelcol-ebpf-profiler, otelcol-contrib distributions, the resourcedetection processor will have version v0.143.0 instead of v0.144.0. You can check the version included in your binary of this or any other component by using the components subcommand:
Output of v0.144.0 otelcol-contrib subcommands
$ ./otelcol-contrib --version
otelcol-contrib version 0.144.0
$ ./otelcol-contrib components | grep v0.143.0
module: github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor v0.143.0This means that all changes between v0.143.0 and v0.144.0 of the resourcedetection processor are not available on these binaries. You can see the full list of changes on this list. The main relevant changes include:
- Avoid panic when detector returns zero-valued pdata resource opentelemetry-collector-contrib#45405
- [processor/resourcedetection] Improve performance on MergeResource and detectedResource opentelemetry-collector-contrib#45251
- [processor/resourcedetection] add container.image.name and container.name resource attributes opentelemetry-collector-contrib#44898
- [processor/resourcedetection] Fix nil pointer panic when HTTP client creation fails in Start method opentelemetry-collector-contrib#45221
None of these changes fix critical bugs, so you can just wait until the next version to include this changes.
Why did this happen?
When following step 1 on the release procedure, the dependency PR was not created, so I forced its creation by clicking the box at the bottom of #720. Not enough time had passed since I had pushed the tags on the opentelemetry-collector-contrib repository so the Golang proxy had not picked up this particular module (in particular, I suspect, this module had been added to the 30 minutes negative cache from the proxy).
This meant that PR #1347 did not include the bump for this module, but (luckily?) the build did work. This was missed by me and others during review.