Support the new max_attempts and max_splits in the sequence file export.#3569
Open
justinuang wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
Support the new max_attempts and max_splits in the sequence file export.#3569justinuang wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
justinuang wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
justinuang
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
=============================================
+ Coverage 37.00% 52.17% +15.17%
- Complexity 470 5647 +5177
=============================================
Files 194 1040 +846
Lines 11376 63074 +51698
Branches 1127 6916 +5789
=============================================
+ Hits 4210 32912 +28702
- Misses 6831 27930 +21099
- Partials 335 2232 +1897
🚀 New features to boost your workflow:
|
justinuang
force-pushed
the
Dataflow_Improvements
branch
from
e3c7b75 to
747d460
Compare
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the bigtableMaxAttempts parameter to the Cloud_Bigtable_to_GCS_SequenceFile Dataflow template. This is the Dataflow side of the implementation, exposing the parameter in the template metadata so it can be passed to the underlying ExportJob (which already supports it via the java-bigtable-hbase library).