Skip to content

fix(asr): mask padded frames after feature normalization#15562

Draft
arushidNV wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
arushidNV:arushid/fix-partial-chunk-normalization
Draft

fix(asr): mask padded frames after feature normalization#15562
arushidNV wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
arushidNV:arushid/fix-partial-chunk-normalization

Conversation

@arushidNV
Copy link
Copy Markdown
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Fixes a buffered ASR normalization bug where padded frames in short final chunks were normalized using valid-frame statistics and could blow up to large values, causing hallucinations.

Collection: ASR

Changelog

  • Update normalize_batch() in nemo/collections/asr/parts/preprocessing/features.py
  • Keep existing valid-frame mean/std computation unchanged
  • Zero out invalid / padded frames after normalization using the existing valid-frame mask
  • Prevent padded tail values from corrupting encoder input for partial last chunks

Usage

  • No API change is required
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@arushidNV arushidNV self-assigned this Mar 30, 2026
@github-actions github-actions bot added the ASR label Mar 30, 2026
@arushidNV arushidNV marked this pull request as draft March 31, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant