fix(507): Add Unicode/IDN domain support to IsURL function#509
Open
varmakarthik12 wants to merge 1 commit intoasaskevich:masterfrom
Open
fix(507): Add Unicode/IDN domain support to IsURL function#509varmakarthik12 wants to merge 1 commit intoasaskevich:masterfrom
varmakarthik12 wants to merge 1 commit intoasaskevich:masterfrom
Conversation
Author
|
Hi @asaskevich, @Dadie, @attilaolah I hope this message finds you well. I would greatly appreciate your review of this pull request, which adds Unicode/IDN domain support to the This PR addresses issue #507 by:
As active contributors and maintainers of this repository, your expertise and feedback would be invaluable in ensuring the quality and compatibility of this enhancement. Thank you for your time and consideration! Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #507 by adding Unicode/IDN (Internationalized Domain Names) support to the IsURL function.
Changes:
patterns.goto include Unicode character ranges (\x{00a1}-\x{ffff})validator_test.goto verify Unicode domain validation works correctlyWhy this change is needed:
Testing:
Fixes #507