client/v3: fix revive unexported-return issues#21512
client/v3: fix revive unexported-return issues#21512eyupcanakman wants to merge 1 commit intoetcd-io:mainfrom
Conversation
Fix the unexported-return revive lint violations in the client/v3 module. Changes: - ordering.NewKV() now returns clientv3.KV instead of *kvOrdering - Export stmOption as STMOption so that WithIsolation(), WithAbortContext(), WithPrefetch(), and NewSTM() no longer return/accept an unexported type Part of etcd-io#18370 Signed-off-by: Eyüp Can Akman <eyupcanakman@gmail.com>
|
Hi @eyupcanakman. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 27 files with indirect coverage changes @@ Coverage Diff @@
## main #21512 +/- ##
==========================================
+ Coverage 68.40% 68.47% +0.06%
==========================================
Files 428 428
Lines 35372 35383 +11
==========================================
+ Hits 24196 24227 +31
+ Misses 9773 9751 -22
- Partials 1403 1405 +2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
||
| type stmOption func(*stmOptions) | ||
| // STMOption configures STM. | ||
| type STMOption func(*stmOptions) |
There was a problem hiding this comment.
Any objections about exporting STMOption, @ahrtr, @serathius, @fuweid?
|
|
||
| type stmOption func(*stmOptions) | ||
| // STMOption configures STM. | ||
| type STMOption func(*stmOptions) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, eyupcanakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Part of #18370
Fix the
unexported-returnrevive lint violations in theclient/v3module.Changes:
ordering.NewKV()now returnsclientv3.KVinstead of*kvOrderingstmOptionasSTMOptionso thatWithIsolation(),WithAbortContext(),WithPrefetch(), andNewSTM()no longer return/accept an unexported type