fix(finance): routingNumber now uses real FederalReserveRoutingSymbol from lookup table.#3429
Open
woldaker wants to merge 8 commits intofaker-js:nextfrom
Open
fix(finance): routingNumber now uses real FederalReserveRoutingSymbol from lookup table.#3429woldaker wants to merge 8 commits intofaker-js:nextfrom
woldaker wants to merge 8 commits intofaker-js:nextfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3290
finance.routingNumber is now comprised as follows:
Digits 0-3 = Pulled from locales/base/finance/federal_reserve_routing_symbol.ts
Digits 4-7 = Random
Digit 8 = Check digit. Calculated from the previous 8 digits as before.
Added more test conditions to the randomly-seeded finance.routingNumber test.