fix(parsers.influx): check for nil metric to prevent panic on invalid input#18641
Open
majiayu000 wants to merge 1 commit intoinfluxdata:masterfrom
Open
fix(parsers.influx): check for nil metric to prevent panic on invalid input#18641majiayu000 wants to merge 1 commit intoinfluxdata:masterfrom
majiayu000 wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
… input When the Ragel state machine completes without calling SetMeasurement(), h.metric remains nil. Calling Metric() then panics on nil dereference at h.metric.Time(). Add a nil guard so Metric() returns nil, which parser.go:106-108 already handles by skipping the entry. Closes influxdata#18228 Signed-off-by: majiayu000 <1835304752@qq.com>
telegraf-tiger
bot
added
fix
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricHandler.Metric()panics on input like\\because the Ragel state machinecompletes without error but never calls
SetMeasurement(), leavingh.metricnil.The subsequent
h.metric.Time()call dereferences nil and crashes.Added a nil check in
Metric()(handler.go:42-44) so it returns nil instead ofpanicking. The caller in parser.go:106-108 already skips nil metrics, so invalid
input just produces no output -- same as other malformed line protocol.
Test added for this case:
[]byte("\\\\")input, expect no metrics and no error.Related issues
resolves #18228