Remove deprecated flag scale-down-enabled

[YahiaBadr]

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Cleanup the deprecated flag scale-down-enabled

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The deprecated flag scale-down-enabled is removed, passing it will break cluster-autoscaler

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @YahiaBadr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[x13n]

I see the flag was deprecated recently - while I agree we should remove it, what's the timeline? Won't both marking as deprecated and actual removal land in the same minor (1.36)?

[x13n]

Since you're changing this anyway, could you factor out scale down logic to a separate function?

[YahiaBadr]

done

[YahiaBadr]

@x13n The deprecation PR was created in January #9056 and was cherry picked to 1.35 #9060. I am not quite familiar with the deprecation policy, so please let me know if 2 months is not enough period alongside having deprecation in 1.35.

If we have to wait I can then close the PR and wait for more time before removing the flag entirely.

[x13n]

Ah, you're right, I see it was deprecated in CA 1.35.0. Removing now so it doesn't exist in 1.36.0 seems reasonable.

[x13n]

/ok-to-test
/assign

[x13n]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x13n, YahiaBadr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment