Skip to content

Add +k8s:maxBytes and +k8s:minBytes OpenAPI representation#578

Open
BasavarajBankolli wants to merge 1 commit intokubernetes:masterfrom
BasavarajBankolli:openapi-maxbytes-137613
Open

Add +k8s:maxBytes and +k8s:minBytes OpenAPI representation#578
BasavarajBankolli wants to merge 1 commit intokubernetes:masterfrom
BasavarajBankolli:openapi-maxbytes-137613

Conversation

@BasavarajBankolli
Copy link
Copy Markdown

@BasavarajBankolli BasavarajBankolli commented Mar 12, 2026

What this PR does

Adds support for the +k8s:maxBytes and +k8s:minBytes validation markers in kube-openapi.

These markers are mapped to OpenAPI maxLength and minLength respectively, allowing byte-based validation constraints to be expressed in API definitions.

Implementation

  • Added MaxBytes and MinBytes fields to commentTags
  • Added validation for negative values and range conflicts
  • Prevented simultaneous use of maxLength with maxBytes and minLength with minBytes
  • Mapped byte markers to length constraints during schema generation

Fixes: kubernetes/kubernetes#137613

Signed-off-by: Basavaraj PB <basavarajbankolli76@gmail.com>
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 12, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: BasavarajBankolli / name: pb (985bc44)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BasavarajBankolli
Once this PR has been reviewed and has the lgtm label, please assign apelisse for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @BasavarajBankolli!

It looks like this is your first PR to kubernetes/kube-openapi 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-openapi has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 12, 2026
@BasavarajBankolli
Copy link
Copy Markdown
Author

@Jefftree @yujuhong could you please review this PR?

@Jefftree
Copy link
Copy Markdown
Member

/assign @aaron-prindle

Will pass this onto the declarative validation folks.

@BasavarajBankolli
Copy link
Copy Markdown
Author

Thanks! Appreciate you routing this to the declarative validation folks.
Happy to make any changes or provide more context if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Declarative Validation] +k8s:[min|max]Bytes openAPI representation

4 participants