Skip to content

Add validation-gen to pined tools#138104

Open
soltysh wants to merge 1 commit intokubernetes:masterfrom
soltysh:validation_gen_tools
Open

Add validation-gen to pined tools#138104
soltysh wants to merge 1 commit intokubernetes:masterfrom
soltysh:validation_gen_tools

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented Mar 30, 2026

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

After we landed #131755 in 1.35 I can't properly use kube_codegen.sh because it requires k8s.io/code-generator/cmd/validation-gen but that is not in the tools, so that when you just pin k8s.io/code-generator it should include all the necessary tools.

Which issue(s) this PR is related to:

Special notes for your reviewer:

/assign @jpbetz

Does this PR introduce a user-facing change?

NONE

@soltysh
Add validation-gen to pined tools
2da9d13 
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 30, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 30, 2026
jpbetz
jpbetz approved these changes Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 30, 2026

LGTM label has been added.

DetailsGit tree hash: 4810fd5d8bb2dd22ad58ef1c60cbd6db750a3d44

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Mar 30, 2026

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 30, 2026
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented Mar 30, 2026

/test pull-kubernetes-unit
/test pull-kubernetes-integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

1 more reviewer

@jpbetz jpbetz jpbetz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpbetz jpbetz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soltysh @k8s-ci-robot @jpbetz