refactor(BA-5490): Rename integration_id to integration_name above model layer#10645
Open
hhoikoo wants to merge 10 commits intofeat/BA-5022/k8s-bridge-access-controlfrom
Open
Conversation
github-actions
bot
added
size:L
hhoikoo
added a commit
that referenced
this pull request
Mar 30, 2026
Add towncrier news fragment for PR #10645. Update GraphQL schema, supergraph, and admin API docs to reflect the integration_id to integration_name rename.
…del layer The _id suffix on integration_id implied a UUID in this codebase, but it is actually an arbitrary external identifier string. Rename the field to integration_name at all layers above the DB model (DTOs, adapters, GQL types, data types, creators, updaters, client SDK, conditions) for users, domains, and groups. The DB column remains integration_id — no migration needed. Mapping seam comments explain the name difference at each ORM-to-data-type boundary.
Co-authored-by: octodog <mu001@lablup.com>
Add towncrier news fragment for PR #10645. Update GraphQL schema, supergraph, and admin API docs to reflect the integration_id to integration_name rename.
Keep integration_id as the field name in GQL types (both legacy and v2), DTOs, REST endpoints, and client SDK to avoid breaking frontend clients. The rename to integration_name is limited to internal layers: data types, creators, updaters, conditions, and RBACModels. Adapters bridge the name difference at the API boundary.
Co-authored-by: octodog <mu001@lablup.com>
Restore all external API files (DTOs, GQL types, client SDK, docs, schema) exactly from base branch. Only bridge at adapter/handler boundary where internal integration_name meets external integration_id. Fix stray description string changes.
The DTO uses integration_id (external API surface), not integration_name (internal data type).
hhoikoo
force-pushed
the
refactor/BA-5490/rename-integration-id-to-name
branch
from
8a049ed to
c65e100
Compare
Since the follow-up BA-5025 modifies the supergraph anyway and all code is on the same unreleased epic branch, rename integration_id to integration_name across the full stack: DTOs, GQL types, client SDK, REST endpoints, docs, and schema files. Adapters no longer need to bridge between different field names.
Co-authored-by: octodog <mu001@lablup.com>
| allowed_docker_registries: [String] | ||
| dotfiles: Bytes | ||
| integration_id: String | ||
| integration_name: String |
Collaborator
There was a problem hiding this comment.
I'm worried that changing the existing fields might cause issues—will this work fine in the web UI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #10644 (BA-5490)
Rename
integration_idtointegration_nameat every layer above the DB model toaddress reviewer feedback that the
_idsuffix implies a UUID in this codebase. Theunderlying DB column (
integration_id) is intentionally left unchanged, so nomigration is required. At each ORM-to-data-type boundary a mapping-seam comment
(
# DB column is integration_id) explains the name difference.Affected entities: users, domains, groups / projects, and resource groups.
Layers touched (54 files):
DomainData,GroupData,UserDataand their modifiers)DomainModel,ProjectModel)DomainConditions)func/domain.py,func/group.py,output/fields.py)Checklist: (if applicable)
ai.backend.testdocsdirectory📚 Documentation preview 📚: https://sorna--10645.org.readthedocs.build/en/10645/
📚 Documentation preview 📚: https://sorna-ko--10645.org.readthedocs.build/ko/10645/