Skip to content

[consteig] Add consteig 1.0.0#50827

Draft
MitchellThompkins wants to merge 4 commits intomicrosoft:masterfrom
MitchellThompkins:add-consteig-1.0.0
Draft

[consteig] Add consteig 1.0.0#50827
MitchellThompkins wants to merge 4 commits intomicrosoft:masterfrom
MitchellThompkins:add-consteig-1.0.0

Conversation

@MitchellThompkins
Copy link
Copy Markdown

@MitchellThompkins MitchellThompkins commented Mar 30, 2026

  • Changes comply with the maintainer guide.
  • The packaged project shows strong association with the chosen port name. Check this box if at least one of the following criteria is met:
    • The project is in Repology: https://repology.org//versions
    • The project is amongst the first web search results for "" or " C++". Include a screenshot of the search engine results in the PR.
    • The port name follows the 'GitHubOrg-GitHubRepo' form or equivalent Owner-Project form.
  • Optional dependencies of the build are all controlled by the port. A dependency is controlled if it is declared an unconditional dependency in vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGE
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is brief and accurate. See adding-usage for context. Don't add a usage file if the automatically generated usage is correct.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@MitchellThompkins MitchellThompkins changed the title Add consteig 1.0.0 [consteig] Add consteig 1.0.0 Mar 30, 2026
@MitchellThompkins
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO MitchellThompkins/consteig
REF "1.0.0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REF "1.0.0"
REF "{VERSION}"

If this matches the version in vcpkg.json, we can make this change to simplify changes in the future.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed by d1cde47

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
-DCONSTEIG_VERSION=1.0.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-DCONSTEIG_VERSION=1.0.0
-DCONSTEIG_VERSION="${VERSION}"

Ensures that the version doesn't get desynchronized if someone forgets to update this line.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed by d1cde47

)

vcpkg_cmake_install()
vcpkg_cmake_config_fixup(PACKAGE_NAME consteig CONFIG_PATH lib/cmake/consteig)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_cmake_config_fixup(PACKAGE_NAME consteig CONFIG_PATH lib/cmake/consteig)
vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/consteig)

PACKAGE_NAME is not necessary in this case.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed by d1cde47

@@ -0,0 +1,24 @@
vcpkg_from_github(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_from_github(
set(VCPKG_BUILD_TYPE release) # header-only library
vcpkg_from_github(

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be addressed by d1cde47

@vicroms vicroms marked this pull request as draft March 30, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants