Remove support for searchable option groups #306515
Open
mjbvz wants to merge 3 commits intomicrosoft:mainfrom
Open
Remove support for searchable option groups #306515mjbvz wants to merge 3 commits intomicrosoft:mainfrom
mjbvz wants to merge 3 commits intomicrosoft:mainfrom
Conversation
This no longer appears to be used
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the (apparently unused) “searchable option groups” capability from the Chat Sessions proposed API and the corresponding UI/IPC plumbing in the workbench and sessions window, simplifying option-group pickers to a single non-searchable implementation.
Changes:
- Removes
searchable/onSearchfromChatSessionProviderOptionGroup(proposed API) and from internal option group types. - Deletes the
SearchableOptionPickerActionItemimplementation and updates chat/session picker UI to always useChatSessionPickerActionItem. - Removes the ext host ↔ main thread protocol method for option-group search and updates tests accordingly.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts | Removes searchable option group API surface from the proposal. |
| src/vs/workbench/contrib/chat/common/chatSessionsService.ts | Drops searchable/onSearch from internal option group type; tweaks setOptionGroupsForSessionType to accept readonly. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Removes searchable picker wiring; always instantiates ChatSessionPickerActionItem. |
| src/vs/workbench/contrib/chat/browser/chatSessions/searchableOptionPickerActionItem.ts | Deletes the searchable QuickPick-based picker implementation. |
| src/vs/workbench/api/test/browser/mainThreadChatSessions.test.ts | Removes now-obsolete $invokeOptionGroupSearch test stub. |
| src/vs/workbench/api/common/extHostChatSessions.ts | Stops propagating searchable and removes the search invocation endpoint. |
| src/vs/workbench/api/common/extHost.protocol.ts | Removes $invokeOptionGroupSearch from the ext host shape. |
| src/vs/workbench/api/browser/mainThreadChatSessions.ts | Stops bridging searchable groups into callbacks; passes option groups through directly. |
| src/vs/sessions/contrib/chat/browser/extensionToolbarPickers.ts | Removes searchable picker usage in the sessions window toolbar pickers. |
justschen
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This no longer appears to be use
cc @DonJayamanne