[cmd/mdatagen] Handle default values for configuration fields in generated code.#15018
Open
jkoronaAtCisco wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[cmd/mdatagen] Handle default values for configuration fields in generated code.#15018jkoronaAtCisco wants to merge 2 commits intoopen-telemetry:mainfrom
jkoronaAtCisco wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (80.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15018 +/- ##
==========================================
- Coverage 91.22% 91.17% -0.05%
==========================================
Files 697 697
Lines 44627 44807 +180
==========================================
+ Hits 40710 40853 +143
- Misses 2773 2806 +33
- Partials 1144 1148 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends
mdatagen'sconfig code generator to automatically produce createDefaultConfig() (and per-definition createDefaultXxx()) factory functions from default: values declared in the JSON Schema config.Supported default types:
Currently not supported types: object, array (non-object items), date-time strings, x-customType fields, external $refs. Support to those types will be added in separate PRs.
Link to tracking issue
#14560
Testing