[exporterhelper] Improve retry sender log message clarity#15023
Open
Vanshul97 wants to merge 2 commits intoopen-telemetry:mainfrom
Open
[exporterhelper] Improve retry sender log message clarity#15023Vanshul97 wants to merge 2 commits intoopen-telemetry:mainfrom
Vanshul97 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the retry sender log message to reduce user confusion about transient export failures.
Fixes #13943
Problem
The current log message:
This causes concern because:
Fix
Changed the log message to:
Changes:
retry_num: Shows which retry attempt this is, helping operators gauge severityretryNum++before logging: So the logged retry number is 1-based (first retry = 1)retry_numattribute addedTest Plan
TestRetrySenderWithContextTimeoutupdated to expect new message-race