Skip to content

chore: refactor some of the loader tests in mdatagen to be more unity, less integration-like#15025

Open
dmathieu wants to merge 1 commit intoopen-telemetry:mainfrom
dmathieu:mdatagen-more-unity-tests
Open

chore: refactor some of the loader tests in mdatagen to be more unity, less integration-like#15025
dmathieu wants to merge 1 commit intoopen-telemetry:mainfrom
dmathieu:mdatagen-more-unity-tests

Conversation

@dmathieu
Copy link
Copy Markdown
Member

@dmathieu dmathieu commented Mar 30, 2026

Several of the loader_test tests in mdatagen are very much integration-like, and setup a lot of things, when they really should be unit tests.

Every remaining test in loader_test should be dependent on the full mdatagen metadata.

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.20%. Comparing base (a58f96f) to head (3cc0367).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15025      +/-   ##
==========================================
- Coverage   91.22%   91.20%   -0.02%     
==========================================
  Files         697      697              
  Lines       44627    44627              
==========================================
- Hits        40710    40704       -6     
- Misses       2773     2776       +3     
- Partials     1144     1147       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review March 30, 2026 13:51
@dmathieu dmathieu requested review from a team and dmitryax as code owners March 30, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd/mdatagen Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant