[service/telemetry] Fix Prometheus config defaults mismatch when host is explicitly set#15027
Draft
Krishnachaitanyakc wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
[service/telemetry] Fix Prometheus config defaults mismatch when host is explicitly set#15027Krishnachaitanyakc wants to merge 1 commit intoopen-telemetry:mainfrom
Krishnachaitanyakc wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
… mismatch When explicitly configuring the Prometheus endpoint for internal telemetry, the defaults for without_type_suffix, without_units, and without_scope_info now correctly remain true, matching the behavior of implicit defaults. Resolves open-telemetry#13867 Assisted-by: Claude Sonnet 4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user explicitly configures the Prometheus endpoint in internal telemetry (e.g., to change the host), the
without_type_suffix,without_units, andwithout_scope_infofields default tonil, which the Prometheus exporter treats asfalse. This diverges from the implicit defaults where all three aretrue.This PR fixes
MetricsConfigV030.Unmarshalto apply default values oftruefor those three fields when they are not explicitly set, ensuring the behavior is consistent whether or not the user explicitly configures the Prometheus exporter section.Resolves #13867