[chore] [cmd/mdatagen] added CI enforcement for tab identation#15031
Open
ThyTran1402 wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Conversation
ThyTran1402
requested review from
a team,
ArthurSens,
dmathieu and
dmitryax
as code owners
|
|
ThyTran1402
changed the title
ThyTran1402
changed the title
ThyTran1402
changed the title
Member
|
This is a good first step, but it's not enough. Tab indentation would indeed be fixed. But there could also be unneeded imports (that will be removed by You should look at the first PR fixing this, it was heading in the right direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Go template files in
cmd/mdatagenandcmd/buildercould be authored with space indentation instead of tabs, violating Go conventions. This was silently masked incmd/mdatagenbecauseformat.Source()corrected the generated output after template execution but the template source itself stayed broken.In
cmd/builder,no such formatting step existed at all, meaning space-indented templates would produce space-indented generated files directly.Related PRs:
#14669
#14688
#14697
Link to tracking issue
Fixes #14698
Testing
Documentation