Skip to content

otelgrpc: support OTEL_SEMCONV_STABILITY_OPT_IN#8726

Merged
dashpole merged 1 commit intoopen-telemetry:mainfrom
dashpole:otelgrpc_stability_optin
Mar 31, 2026
Merged

otelgrpc: support OTEL_SEMCONV_STABILITY_OPT_IN#8726
dashpole merged 1 commit intoopen-telemetry:mainfrom
dashpole:otelgrpc_stability_optin

Conversation

@dashpole
Copy link
Copy Markdown
Contributor

Fixes #8683

This keeps the default as the new conventions, but supports rpc/dup and rpc/old modes.

The only interesting part is that there is a change to how rpc.method is structured. For the rpc/dup mode, I use the "new" version, rather than the old version.

I used AI to help implement the changes.

@dashpole dashpole force-pushed the otelgrpc_stability_optin branch from bb404fa to 4d84730 Compare March 26, 2026 02:14
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 94.39252% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.2%. Comparing base (c191508) to head (3b1afee).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 92.5% 2 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8726     +/-   ##
=======================================
+ Coverage   82.1%   82.2%   +0.1%     
=======================================
  Files        183     183             
  Lines      13819   13901     +82     
=======================================
+ Hits       11350   11437     +87     
+ Misses      2065    2056      -9     
- Partials     404     408      +4     
Files with missing lines Coverage Δ
...entation/google.golang.org/grpc/otelgrpc/config.go 89.8% <100.0%> (+1.9%) ⬆️
.../google.golang.org/grpc/otelgrpc/internal/parse.go 100.0% <100.0%> (ø)
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 96.5% <92.5%> (-2.0%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dashpole dashpole force-pushed the otelgrpc_stability_optin branch 2 times, most recently from 2ac1049 to 6e4ca88 Compare March 29, 2026 18:38
@dashpole dashpole marked this pull request as ready for review March 29, 2026 18:44
@dashpole dashpole requested a review from a team as a code owner March 29, 2026 18:44
@dmathieu
Copy link
Copy Markdown
Member

Would it make sense to have the semantic convention logic in its own package, like we did for the HTTP packages?

@dashpole
Copy link
Copy Markdown
Contributor Author

Would it make sense to have the semantic convention logic in its own package, like we did for the HTTP packages?

I would prefer keeping it in the package. The actual logic to switch between old/new/dup isn't too complicated, IMO. The changes for the rpc migration seem a lot simpler than they were for the http migration, which helps. If we split into a new package, it is just more for us to revert later.

Signed-off-by: David Ashpole <dashpole@google.com>
@dashpole dashpole force-pushed the otelgrpc_stability_optin branch from 9d2519a to 3b1afee Compare March 30, 2026 20:27
@dashpole dashpole merged commit b9c3aea into open-telemetry:main Mar 31, 2026
46 of 47 checks passed
@dashpole dashpole deleted the otelgrpc_stability_optin branch March 31, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: otelgrpc should support OTEL_SEMCONV_STABILITY_OPT_IN for breaking changes

3 participants