otelgrpc: support OTEL_SEMCONV_STABILITY_OPT_IN#8726
Merged
dashpole merged 1 commit intoopen-telemetry:mainfrom Mar 31, 2026
Merged
otelgrpc: support OTEL_SEMCONV_STABILITY_OPT_IN#8726dashpole merged 1 commit intoopen-telemetry:mainfrom
dashpole merged 1 commit intoopen-telemetry:mainfrom
Conversation
bb404fa to
4d84730
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8726 +/- ##
=======================================
+ Coverage 82.1% 82.2% +0.1%
=======================================
Files 183 183
Lines 13819 13901 +82
=======================================
+ Hits 11350 11437 +87
+ Misses 2065 2056 -9
- Partials 404 408 +4
🚀 New features to boost your workflow:
|
2ac1049 to
6e4ca88
Compare
Member
|
Would it make sense to have the semantic convention logic in its own package, like we did for the HTTP packages? |
Contributor
Author
I would prefer keeping it in the package. The actual logic to switch between old/new/dup isn't too complicated, IMO. The changes for the rpc migration seem a lot simpler than they were for the http migration, which helps. If we split into a new package, it is just more for us to revert later. |
dmathieu
approved these changes
Mar 30, 2026
pellared
approved these changes
Mar 30, 2026
Signed-off-by: David Ashpole <dashpole@google.com>
9d2519a to
3b1afee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8683
This keeps the default as the new conventions, but supports
rpc/dupandrpc/oldmodes.The only interesting part is that there is a change to how rpc.method is structured. For the
rpc/dupmode, I use the "new" version, rather than the old version.I used AI to help implement the changes.