feat: Standardize otap nullable and optional columns#2450
Open
JakeDern wants to merge 15 commits intoopen-telemetry:mainfrom
Open
feat: Standardize otap nullable and optional columns#2450JakeDern wants to merge 15 commits intoopen-telemetry:mainfrom
JakeDern wants to merge 15 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2450 +/- ##
==========================================
- Coverage 88.18% 88.17% -0.01%
==========================================
Files 604 604
Lines 214589 214724 +135
==========================================
+ Hits 189235 189342 +107
- Misses 24828 24858 +30
+ Partials 526 524 -2
🚀 New features to boost your workflow:
|
3b50826 to
d00d4ac
Compare
Contributor
Author
|
I think the test failures here are also unrelated, but it still makes me a bit uncomfortable as this is a riskier change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This is a spec compliance PR overhauling the relationship between nullable and optional columns as described in #2149 across both go and rust implementations.
Major changes:
What issue does this PR close?
How are these changes tested?
Are there any user-facing changes?