[WIP] Add standalone control-aware bounded channel for future engine integration#2466
Draft
lquerel wants to merge 13 commits intoopen-telemetry:mainfrom
Draft
[WIP] Add standalone control-aware bounded channel for future engine integration#2466lquerel wants to merge 13 commits intoopen-telemetry:mainfrom
lquerel wants to merge 13 commits intoopen-telemetry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Not ready for review yet **
Change Summary
Add a new standalone
control-channelcrate that defines a bounded control-aware channel for OTAP node-control traffic.This change is intended as a first step toward the broader engine redesign tracked in #2465. It introduces the control-channel design, tests, benchmarks, and documentation in a standalone form so the control-plane semantics can be reviewed and validated before integration into the engine runtime.
The new channel is designed for the control-path requirements of the OTAP engine:
DrainIngressandShutdownAck/NackhandlingTimerTick/CollectTelemetryConfigAckMsg<PData, Meta>/NackMsg<PData, Meta>for future engine unwind-state integrationThis PR does not yet wire the new control channel into receivers, processors, exporters, or
pipeline_ctrl. That integration is planned in the later steps of #2465.What issue does this PR close?
How are these changes tested?
control-channelcrate covering:current engine control-channel paths under heavy
Ack/Nacktraffic andmixed control noise
cargo xtask checkBenchmark results
Ack/Nack Only
Ack/Nack + Control Noise
Notes:
control_awareis the standalone single-owner channel introduced in this PR.current_sharedis included as a reference against the current engine shared path.Are there any user-facing changes?
No user-facing behavior changes yet.
This PR adds the standalone control channel and its validation/benchmarking surface, but does not yet integrate it into the engine runtime.